Code review

Mjolnir reviews committed work before push whenever reviewers are configured. A reviewer runs as a hidden child session and uses the model and effort selected for its reviewer slot. Open Reviewers on the prompt’s bottom border to read its conversation.

Configure reviewers

Settings → Code Review selects up to three reviewer rows. Each row has a model and effort. Autoconfigure fills the rows from models offered by enabled profiles. At review time, Mjolnir chooses an enabled profile offering each row’s model and effort.

[review]
[[review.reviewers]]
model = "gpt-6.10-terra"
effort = "xhigh"

An empty list means no reviewers are configured. Press Autoconfigure in Settings → Code Review to choose reviewers. It chooses the first available combination: Terra, Sol, and Haiku; Terra and Sol; three Haiku; two DeepSeek Flash; Grok; or Kimi K3.1 or newer. It uses the newest advertised model within each family. If no combination is available, choose reviewers in Settings → Code Review. A session-level --reviewer choice enables review unless that session uses --review off.

Old count, profile, model, effort, tier, trigger, and enabled config keys remain readable; trigger and enabled are dropped when settings are saved. An existing config without [review], or a [review] table without reviewers and model, retains the old Auto selection. The daemon saves reviewer rows after capability discovery succeeds; if discovery fails, it retries. Other settings saves preserve this pending selection. A fresh config starts with no reviewers. An explicit reviewers = [] stays empty.

Per-session settings

mj new and mj import <harness> accept --review off|push and repeatable --reviewer MODEL[:EFFORT] (up to three). --review off disables review for that session. --review push enables it. --review turn is refused. A session-level reviewer choice replaces the global reviewer list. API review.mode accepts off or push; turn is refused.

Review requires a committed Git checkout. Tracked changes must be committed before review; untracked files are ignored.

Request a review

Claude Code, Codex, and DSH sessions receive the request_review tool from the separate mj-review MCP server. The agent commits its work and calls the tool before pushing. /review in Prompt, mj review start, and POST /review also start a push review of committed work. The verdict arrives as a message to the agent. If a review cannot start, the requester sees the reason. mj review status shows the open review and verdict.

Reviewers read the whole change from its review base. They do not receive prior findings for a corrective pass. A findings verdict tells the agent to address findings and request review again.

The review starts from the last cleanly reviewed commit when that commit is in the current history and is not older than the merge base with the default branch. Otherwise, it starts from that merge base. If the agent merges newer default-branch commits into reviewed work, the review covers only conflict resolutions and later edits.

A clean review advances the review base. It records the reviewed tree in refs/mj/reviewed/<tree>. The ref follows the repository through Mjolnir checkpoints.

Overrides and review base

The override_review tool takes pairs of findings and reasons for findings the agent will not fix. The agent should record these before committing other fixes. The override allows pushing the exact reviewed commits, but does not move the review base. Mjolnir records overridden trees in refs/mj/overridden/<tree> and tells later reviewers not to report declined findings again. The declined list clears when the review base moves.

set_review_baseline(commit, path?) moves the review base through a commit whose tree was reviewed or overridden. Later reviews start after that commit. Moving the base clears the declined list. The tools request_review, override_review, and set_review_baseline are provided by mj-review.

The pre-push hook accepts trees recorded under either refs/mj/reviewed/ or refs/mj/overridden/. A merge of the default branch does not require reviewing changes already covered by the prior review base.

Follow a review

The parent conversation and its prompt remain available while reviewers work. A short status appears above the prompt. Open Reviewers to inspect reviewer sessions in the virtual workspace; close the workspace or press Escape in the Sessions list to return. The web viewer works the same way: Reviewers · n, with the number of reviewers still open, sits beside Subagents · n once a session has any reviewer, and opens the same list filtered to reviewers. Subagents lists only the other children.

A clean review advances the reviewed boundary automatically. Findings arrive as a message to the primary agent, and a failed review reports its reason. mj review status shows the current state and verdict.

Lifecycle behavior

New eligible primary sessions capture a review baseline even when automatic review is off. A session is eligible when an enabled profile can serve review choices. A session started without a baseline must be resumed or restarted after configuring an eligible reviewer. Child sessions do not capture independent review baselines.

Suspending a session while a review is open preserves its result for reference. The reviewer’s worker cannot continue after the target is destroyed. A later review starts a new reviewer child session.

While a review is preparing or running, Mjolnir starts no recovery copy or worker upgrade for that session; a copy already running when the review begins is finished first. Deferred copies and upgrades start as soon as the review closes.

If Mjolnir restarts during a review, the reviewer workers keep running. The replacement daemon restores the captured target, reviewer sessions, and completed results, then continues the group. A repeated result does not duplicate findings or approve the tree twice. Reviews interrupted before their group could be saved remain unreviewed rather than advancing coverage.

Review traffic is charged through the selected reviewer profile. A different profile ID may still share account-level limits with the primary profile. See configuration for schema details.